r176617 - Add flags for additional control over coverage generation. Pick the version

[Chandler Carruth]

On Thu, Mar 7, 2013 at 12:28 AM, Nick Lewycky <nicholas at mxc.ca> wrote:

> +    if (Args.hasArg(OPT_coverage_version_EQ)) {
> +      StringRef CoverageVersion =
> Args.getLastArgValue(OPT_coverage_version_EQ);
> +      if (CoverageVersion.size() != 4) {
> +        Diags.Report(diag::err_drv_invalid_value)
> +            << Args.getLastArg(OPT_coverage_version_EQ)->getAsString(Args)
> +            << CoverageVersion;
> +      } else {
> +        Opts.CoverageVersion[0] = CoverageVersion[3];
> +        Opts.CoverageVersion[1] = CoverageVersion[2];
> +        Opts.CoverageVersion[2] = CoverageVersion[1];
> +        Opts.CoverageVersion[3] = CoverageVersion[0];
>

Not just this patch, but with all of these patches, I'd really like some
comments explaining exactly what the options, strings, etc. all mean. What
are the expected values? What are valid values? Why is this reversed?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130307/cbb67688/attachment.html>