<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 7, 2013 at 12:28 AM, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca" target="_blank" class="cremed">nicholas@mxc.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":jji">+    if (Args.hasArg(OPT_coverage_version_EQ)) {<br>
+      StringRef CoverageVersion = Args.getLastArgValue(OPT_coverage_version_EQ);<br>
+      if (CoverageVersion.size() != 4) {<br>
+        Diags.Report(diag::err_drv_invalid_value)<br>
+            << Args.getLastArg(OPT_coverage_version_EQ)->getAsString(Args)<br>
+            << CoverageVersion;<br>
+      } else {<br>
+        Opts.CoverageVersion[0] = CoverageVersion[3];<br>
+        Opts.CoverageVersion[1] = CoverageVersion[2];<br>
+        Opts.CoverageVersion[2] = CoverageVersion[1];<br>
+        Opts.CoverageVersion[3] = CoverageVersion[0];</div></blockquote></div><br>Not just this patch, but with all of these patches, I'd really like some comments explaining exactly what the options, strings, etc. all mean. What are the expected values? What are valid values? Why is this reversed?</div>
</div>