r174810 - Comment parsing: use CharInfo.h

Sean Silva silvas at purdue.edu
Sat Feb 9 13:47:43 PST 2013


namespace {
 bool isHTMLNamedCharacterReferenceCharacter(char C) {
-  return (C >= 'a' && C <= 'z') ||
-         (C >= 'A' && C <= 'Z');
+  return isLetter(C);
 }

FYI, the preference is to use static for these kind of helper functions: <
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces>.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130209/23ec18c8/attachment.html>


More information about the cfe-commits mailing list