r174810 - Comment parsing: use CharInfo.h

Dmitri Gribenko gribozavr at gmail.com
Sun Feb 10 03:55:01 PST 2013


On Sat, Feb 9, 2013 at 11:47 PM, Sean Silva <silvas at purdue.edu> wrote:
> namespace {
>  bool isHTMLNamedCharacterReferenceCharacter(char C) {
> -  return (C >= 'a' && C <= 'z') ||
> -         (C >= 'A' && C <= 'Z');
> +  return isLetter(C);
>  }
>
> FYI, the preference is to use static for these kind of helper functions:
> <http://llvm.org/docs/CodingStandards.html#anonymous-namespaces>.

Thanks, fixed up in r174835.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list