Patch to accept over-qualified constructor in MSVC emulation mode

Jason Haslam jason.haslam at gmail.com
Fri Feb 8 10:13:19 PST 2013


Ping. Any interest in this?

Jason


On Feb 6, 2013, at 2:19 PM, Jason Haslam <jason.haslam at gmail.com> wrote:

> MSVC accepts this:
> 
> class A {
>  A::A();
> };
> 
> Clang accepts regular member functions with extra qualification as an MS extension, but not constructors. The attached patch changes the parser to defer rejecting qualified constructors so that the same Sema logic can apply to constructors as regular member functions. This also improves the error message when MS extensions are disabled (in my opinion). Before it was:
> 
> /Users/jason/Desktop/test.cpp:2:8: error: expected member name or ';' after declaration specifiers
>  A::A();
>  ~~~~ ^
> 1 error generated.
> 
> After:
> 
> /Users/jason/Desktop/test.cpp:2:6: error: extra qualification on member 'A'
>  A::A();
>  ~~~^
> 1 error generated.
> 
> All tests pass and I added one additional test for this case.
> 
> Jason
> 
> <over-qualified-ctor.diff>





More information about the cfe-commits mailing list