Patch to accept over-qualified constructor in MSVC emulation mode

Jason Haslam jason.haslam at
Wed Feb 6 13:19:28 PST 2013

MSVC accepts this:

class A {

Clang accepts regular member functions with extra qualification as an MS extension, but not constructors. The attached patch changes the parser to defer rejecting qualified constructors so that the same Sema logic can apply to constructors as regular member functions. This also improves the error message when MS extensions are disabled (in my opinion). Before it was:

/Users/jason/Desktop/test.cpp:2:8: error: expected member name or ';' after declaration specifiers
  ~~~~ ^
1 error generated.


/Users/jason/Desktop/test.cpp:2:6: error: extra qualification on member 'A'
1 error generated.

All tests pass and I added one additional test for this case.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: over-qualified-ctor.diff
Type: application/octet-stream
Size: 2237 bytes
Desc: not available
URL: <>

More information about the cfe-commits mailing list