r174576 - Simplify FindExternalVisibleDeclsByName by making it return a bool indicating

Sean Silva silvas at purdue.edu
Wed Feb 6 22:06:47 PST 2013

On Wed, Feb 6, 2013 at 11:48 PM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Wed, Feb 6, 2013 at 8:41 PM, Sean Silva <silvas at purdue.edu> wrote:
>>    /// \brief Finds all the visible declarations with a given name.
>>    /// The current implementation of this method just loads the entire
>>    /// lookup table as unmaterialized references.
>> -  virtual DeclContext::lookup_result
>> +  virtual bool
>> Bool return arguments probably deserve a mention in the comment, due to
>> their notorious ambiguity.
> This is an overload of a virtual function; the return value is described
> in the base class.

Ah ok.

Do we have a policy on how to document virtual overrides?

Not that I know of.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130207/bb45d9c0/attachment.html>

More information about the cfe-commits mailing list