r174576 - Simplify FindExternalVisibleDeclsByName by making it return a bool indicating

Richard Smith richard at metafoo.co.uk
Wed Feb 6 20:48:14 PST 2013

On Wed, Feb 6, 2013 at 8:41 PM, Sean Silva <silvas at purdue.edu> wrote:

>    /// \brief Finds all the visible declarations with a given name.
>    /// The current implementation of this method just loads the entire
>    /// lookup table as unmaterialized references.
> -  virtual DeclContext::lookup_result
> +  virtual bool
> Bool return arguments probably deserve a mention in the comment, due to
> their notorious ambiguity.

This is an overload of a virtual function; the return value is described in
the base class. Do we have a policy on how to document virtual overrides?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130206/d80dca67/attachment.html>

More information about the cfe-commits mailing list