[PATCH] RE: [cfe-commits] r173697 - FileCheck'ize and merge tests

Benyei, Guy guy.benyei at intel.com
Wed Feb 6 12:42:00 PST 2013

Thanks, patch committed to revision 174541.

Guy Benyei

-----Original Message-----
From: Dmitri Gribenko [mailto:gribozavr at gmail.com] 
Sent: Wednesday, February 06, 2013 22:12
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] RE: [cfe-commits] r173697 - FileCheck'ize and merge tests

On Wed, Feb 6, 2013 at 10:05 PM, Benyei, Guy <guy.benyei at intel.com> wrote:
> Thanks Dmitri,
> I've fixed your comments.
> About the test - I'm not exactly sure how to test this change - I'm not sure if committing a DOS-style file will work right. Any ideas?

It should work.  Just put a comment explaining that the file is testing that FileCheck is insensitive to newline kind, and other developers should not "fix" the file by converting it to UNIX-style newlines.

LGTM with test.


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the cfe-commits mailing list