[PATCH] RE: [cfe-commits] r173697 - FileCheck'ize and merge tests

Dmitri Gribenko gribozavr at gmail.com
Wed Feb 6 12:12:17 PST 2013

On Wed, Feb 6, 2013 at 10:05 PM, Benyei, Guy <guy.benyei at intel.com> wrote:
> Thanks Dmitri,
> I've fixed your comments.
> About the test - I'm not exactly sure how to test this change - I'm not sure if committing a DOS-style file will work right. Any ideas?

It should work.  Just put a comment explaining that the file is
testing that FileCheck is insensitive to newline kind, and other
developers should not "fix" the file by converting it to UNIX-style

LGTM with test.


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/

More information about the cfe-commits mailing list