[cfe-commits] clang formatter patch to move and rename RewriterTestContext.h

[jahanian]

On Dec 20, 2012, at 9:02 AM, Daniel Jasper <djasper at google.com> wrote:

> Hi,
> 
> ok, some comments here, but after the discussions it seems like this can mostly go in as is

> 
> +    TT_BlockComment,
> +    TT_ObjectiveCMethodDecl
>    };
> 
> The +/- actually determine whether it is an instance or a static method, right? If so, we might want to hint at that in this name.
> 
> 
> +      else if ((Tok.Tok.is(tok::minus) || Tok.Tok.is(tok::plus)) &&
> +               Tok.Tok.isAtStartOfLine())
> +        Annotation.Type = TokenAnnotation::TT_ObjectiveCMethodDecl;
> 
> I think it might be easier to set this in the AnnotatingParser. But that entire part needs cleanup so I'd be ok with you checking it in for now.
> 
> Cheers,
> Daniel
> 

Checked in r170727.
- Thanks, Fariborz



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121220/373a6b23/attachment.html>