<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 20, 2012, at 9:02 AM, Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr">Hi,<div><br></div><div style="">ok, some comments here, but after the discussions it seems like this can mostly go in as is</div></div></div></blockquote></div><div><blockquote type="cite"><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr"><div style="">
<br></div><div style=""><div>+ TT_BlockComment,</div><div>+ TT_ObjectiveCMethodDecl</div><div> };</div><div><br></div><div style="">The +/- actually determine whether it is an instance or a static method, right? If so, we might want to hint at that in this name.</div>
<div style=""><br></div><div style=""><br></div><div style=""><div>+ else if ((<a href="http://tok.tok.is/">Tok.Tok.is</a>(tok::minus) || <a href="http://tok.tok.is/">Tok.Tok.is</a>(tok::plus)) &&</div><div>+ Tok.Tok.isAtStartOfLine())</div>
<div>+ Annotation.Type = TokenAnnotation::TT_ObjectiveCMethodDecl;</div><div><br></div><div style="">I think it might be easier to set this in the AnnotatingParser. But that entire part needs cleanup so I'd be ok with you checking it in for now.</div>
</div></div><div style=""><br></div><div style="">Cheers,<br>Daniel</div></div><div class="gmail_extra"><br></div></div></blockquote><div><br></div><div>Checked in r170727.</div><div>- Thanks, Fariborz</div><div><br></div><div><br></div></div><br></body></html>