[cfe-commits] [PATCH] Simplify isPowerOfTwo signature

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Dec 11 07:43:24 PST 2012

>> We can always add it back that day, no?
> Sure, but if there's no real need to remove it why not leave it alone?
> It seems a rather pointless clean up to me.  That said, I won't object if
> Saleem goes ahead and removes it.

Short of some ABI stability (like in the C api) or generalization of
users (for example, we want a macro to call isPowerOfTwo or other
functions that do need TargetData), I think we should make the code as
simple as possible.

Having the target data makes the function a bit more cumbersome to
call, and a bit more cumbersome to read. Not having it also makes it
clear just by looking at the interface that in doesn't do anything
target dependent.

> Ciao, Duncan.


More information about the cfe-commits mailing list