[cfe-commits] [PATCH] Simplify isPowerOfTwo signature

Duncan Sands baldrick at free.fr
Tue Dec 11 07:12:32 PST 2012

On 11/12/12 16:04, Rafael EspĂ­ndola wrote:
> On 11 December 2012 02:06, Duncan Sands <baldrick at free.fr> wrote:
>> Hi Saleem, why do you want this?  While isPowerOfTwo doesn't use data layout
>> today, it's not unreasonable to imagine that it may use it one day.
> We can always add it back that day, no?

Sure, but if there's no real need to remove it why not leave it alone?
It seems a rather pointless clean up to me.  That said, I won't object if
Saleem goes ahead and removes it.

Ciao, Duncan.

>>   As
>> such,
>> requiring target data can be considered part of the isPowerOfTwo API.
> This is the c++ api, so it is not required to be stable.
>> Ciao, Duncan.
> Cheers,
> Rafael

More information about the cfe-commits mailing list