[cfe-commits] r160034 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/CodeGenCXX/visibility.cpp

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Jul 11 06:30:11 PDT 2012

> In that case, I don't think you need any of these checks there
> except, maybe, isa<CXXRecordDecl>(CurContext);  I believe
> ActOnTagFinishDefinition is called exclusively by the parser.
> Hmm.  I tend to think that this pragma should also apply to enum
> definitions within its scope.  Is that not what GCC does?

It looks like gcc ignores visibility attributes in enums completely.
We already accept it with explicit attributes, so I think we should
accept it with pragmas too or drop the support for it. In any case,
this part of the code should handle tags uniformly.

> John.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 2219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120711/7bf8c327/attachment.obj>

More information about the cfe-commits mailing list