[cfe-commits] r160034 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/CodeGenCXX/visibility.cpp

John McCall rjmccall at apple.com
Tue Jul 10 22:42:38 PDT 2012

On Jul 10, 2012, at 10:16 PM, Rafael EspĂ­ndola wrote:
>> Could this code just reasonably be moved to ActOnTagFinishDefinition?
> Looks like it can.

In that case, I don't think you need any of these checks there
except, maybe, isa<CXXRecordDecl>(CurContext);  I believe
ActOnTagFinishDefinition is called exclusively by the parser.

Hmm.  I tend to think that this pragma should also apply to enum
definitions within its scope.  Is that not what GCC does?


More information about the cfe-commits mailing list