[cfe-commits] [PATCH] Abstract v-table generation into the CGCXXABI interface

Chandler Carruth chandlerc at google.com
Thu Jun 28 16:21:30 PDT 2012


Regressions are not OK. Unless the fix is imminent, we should revert and
work on a correct patch.


On Thu, Jun 28, 2012 at 4:08 PM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> FTR, this patch has regressed:
> http://llvm.org/bugs/show_bug.cgi?id=13231
>
> Now I can't build non-trivial C++ code anymore.
> [I had local patches to work OK on some files and was planning to send
> a few things for review but now I'm literally stuck at ~r158985]
>
> Please fix this ASAP or I'll have to revert it (locally, maybe; but
> this is still not cool).
>
> On Sat, Jun 23, 2012 at 4:50 PM, Charles Davis <cdavis at mymail.mines.edu>
> wrote:
> >
> > On Jun 23, 2012, at 1:11 PM, John McCall wrote:
> >> The remaining trivial patch, which just declares, defines, and calls
> EmitVTables, is approved.
> > Thanks, r159091.
> >
> > Chip
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120628/ef7075b2/attachment.html>


More information about the cfe-commits mailing list