[cfe-commits] Request for approval: Pythonstuff including Cursor.enum_value

Anders Waldenborg andersg at gagarin.0x63.nu
Wed May 2 13:53:39 PDT 2012

On Wed, May 02, 2012 at 07:33:50PM +0200, Manuel Klimek wrote:
> Also, the surrounding style seems to use kSomething for file level
> string constants, so I'd use that for the test, too. In general, I'd
> make it look like the tests in test_cursor.py already do.

Indeed, this was an old patch that popped up when I rebased, and I
should have noticed that it could be rewritten to use the new helpers.

I actually think it makes more sense to put that testcase in

Updated patch attached.

Thanks again for the review.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python-Add-testcase-for-annotation-cursor-kind.patch
Type: text/x-diff
Size: 1145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120502/6daff199/attachment.patch>

More information about the cfe-commits mailing list