[cfe-commits] Request for approval: Pythonstuff including Cursor.enum_value

Manuel Klimek klimek at google.com
Wed May 2 13:58:42 PDT 2012

On Wed, May 2, 2012 at 10:53 PM, Anders Waldenborg
<andersg at gagarin.0x63.nu> wrote:
> On Wed, May 02, 2012 at 07:33:50PM +0200, Manuel Klimek wrote:
>> Also, the surrounding style seems to use kSomething for file level
>> string constants, so I'd use that for the test, too. In general, I'd
>> make it look like the tests in test_cursor.py already do.
> Indeed, this was an old patch that popped up when I rebased, and I
> should have noticed that it could be rewritten to use the new helpers.
> I actually think it makes more sense to put that testcase in
> test_cursor.py.
> Updated patch attached.

Looks good. /me wonders whether we can put something in (perhaps with
lambdas) to prevent having to spell out the loop, but it's probably
not worth it.


More information about the cfe-commits mailing list