[cfe-commits] r149083 - in /cfe/trunk: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/WindowsToolChain.cpp test/Driver/prefixed-tools.c test/Driver/pref

Chandler Carruth chandlerc at google.com
Fri Jan 27 11:16:47 PST 2012

On Fri, Jan 27, 2012 at 8:36 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> > Reverting just this change is inacceptable. It fixes a major regression
> > for cross-compiling support from your earlier changes, without
> > introducing a bag of new ones.
> I am pretty sure the use case you implemented is not desired on linux
> or OS X at least. On OS X we already have -arch working. On linux, we
> should not be specifying an arch and using a toolchain with exactly
> that triple. We should specify a toolchain and have the current
> detection system do its magic.
> You should at a very minimum move this to be NetBSD only.

I actually think this functionality is generically useful. I agree that we
should have better support for finding and using triple-prefixed tools, in
all of the toolchains. However, I think this entire discussion really
belongs on a code review thread, not on the commit logs. That's what I have
a much bigger issue with here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120127/4e23e3f4/attachment.html>

More information about the cfe-commits mailing list