[cfe-commits] [PATCH] Refactor Diagnostic class

Argyrios Kyrtzidis kyrtzidis at apple.com
Wed Nov 17 10:02:13 PST 2010


Bump.

On Nov 15, 2010, at 3:25 PM, Argyrios Kyrtzidis wrote:

> -The attached patch separates Diagnostic class into 2 classes, Diagnostic and DiagnosticIDs.
> -Move the stuff of Diagnostic related to creating/querying diagnostic IDs into the new DiagnosticIDs class.
> -DiagnosticIDs can be shared among multiple Diagnostics for multiple translation units.
> -The rest of the state in Diagnostic object is considered related and tied to one translation unit.
> -Have Diagnostic point to the SourceManager that is related with. Diagnostic can now accept just a SourceLocation instead of a FullSourceLoc.
> -Reflect the changes to various interfaces.
> 
> Please review.
> 
> -Argiris
> 
> <diag-refactor.diff>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list