[cfe-commits] [PATCH] Refactor Diagnostic class

Argyrios Kyrtzidis kyrtzidis at apple.com
Mon Nov 15 15:25:57 PST 2010


-The attached patch separates Diagnostic class into 2 classes, Diagnostic and DiagnosticIDs.
-Move the stuff of Diagnostic related to creating/querying diagnostic IDs into the new DiagnosticIDs class.
-DiagnosticIDs can be shared among multiple Diagnostics for multiple translation units.
-The rest of the state in Diagnostic object is considered related and tied to one translation unit.
-Have Diagnostic point to the SourceManager that is related with. Diagnostic can now accept just a SourceLocation instead of a FullSourceLoc.
-Reflect the changes to various interfaces.

Please review.

-Argiris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: diag-refactor.diff
Type: application/octet-stream
Size: 107365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101115/3901f8a1/attachment.obj>


More information about the cfe-commits mailing list