[cfe-commits] [patch] Implement support for @file

Rafael Espindola espindola at google.com
Fri Jul 16 12:48:24 PDT 2010


On 16 July 2010 13:46, Daniel Dunbar <daniel at zuster.org> wrote:
> Thanks Rafael, sorry for the run around.

NP. A new version is attached. Some observations

*) Nested @files are supported, but I don't know how to test it in "make test"
*) "-Dfoo12=a'b" '-Dfoo12=a"b' produce invalid definitions, since the
right hand side is not a valid token. gcc warns, clang erros.
*) Where should we free the memory? The libiberty version provides an
auxiliary function for the user to call, we can also use std::string
by changing some interfaces (cc1_main) or create some RAII object to
free the memory.

>  - Daniel


Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: at.patch
Type: text/x-patch
Size: 6495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100716/4a1913c4/attachment.bin>


More information about the cfe-commits mailing list