[cfe-commits] [patch] Implement support for @file

Daniel Dunbar daniel at zuster.org
Fri Jul 16 10:46:32 PDT 2010


Thanks Rafael, sorry for the run around.

 - Daniel

On Fri, Jul 16, 2010 at 9:20 AM, Rafael Espindola <espindola at google.com> wrote:
>> Ugh, actually its even more complicated because the ArgList needs to
>> take ownership of the strings. Given this amount of nastiness, and the
>> minorness of the feature, I'm leaning more towards saying lets just
>> take the original patch, and someone can do the extra work to move it
>> into the OptTable if and when someone cares about it being handled by
>> other OptTable clients.
>
> Given that that covers more cases too, I agree :-)
>
> Attached is an update of the second patch with some of the reviews in
> case someone wants to continue on this path. I will port the relevant
> comments to the first patch and send it again.
>
> Cheers,
> --
> Rafael Ávila de Espíndola
>




More information about the cfe-commits mailing list