[cfe-commits] [PATCH] Windows build fix
Chris Lattner
clattner at apple.com
Sat Jul 10 10:29:10 PDT 2010
Looks fine to me, go for it.
On Jul 9, 2010, at 5:18 PM, John Thompson wrote:
> Regarding the bug I posted, 7613, Dimitry Andric responded with a fix that involves letting the build use the default name of libclang for the library, which avoids various conflicts:
>
> Index: tools/libclang/CMakeLists.txt
> ===================================================================
> --- tools/libclang/CMakeLists.txt (revision 107937)
> +++ tools/libclang/CMakeLists.txt (working copy)
> @@ -29,7 +29,6 @@
> CXTypes.cpp
> ../../include/clang-c/Index.h
> )
> -set_target_properties(libclang PROPERTIES OUTPUT_NAME clang)
>
> if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
> # FIXME: Deal with LLVM_SUBMIT_VERSION?
> May I check this in? I didn't find any references to clang.dll in the docs, so hopefully this is the only thing needing changing in the tree. However, I suppose this means clients building against clang.lib will be affected in their build.
>
> -John
>
> --
> John Thompson
> John.Thompson.JTSoftware at gmail.com
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100710/10f4dd5a/attachment.html>
More information about the cfe-commits
mailing list