<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks fine to me, go for it. <div><br><div><div>On Jul 9, 2010, at 5:18 PM, John Thompson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Regarding the bug I posted, 7613, Dimitry Andric responded with a fix that involves letting the build use the default name of libclang for the library, which avoids various conflicts:</div>
<div> </div>
<div>Index: tools/libclang/CMakeLists.txt<br>===================================================================<br>--- tools/libclang/CMakeLists.txt (revision 107937)<br>+++ tools/libclang/CMakeLists.txt (working copy)<br>
@@ -29,7 +29,6 @@<br> CXTypes.cpp<br> ../../include/clang-c/Index.h<br> )<br>-set_target_properties(libclang PROPERTIES OUTPUT_NAME clang)<br> <br> if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")<br> # FIXME: Deal with LLVM_SUBMIT_VERSION?<br>
</div>
<div>May I check this in? I didn't find any references to clang.dll in the docs, so hopefully this is the only thing needing changing in the tree. However, I suppose this means clients building against clang.lib will be affected in their build.</div>
<div> </div>
<div>-John<br clear="all"><br>-- <br>John Thompson<br><a href="mailto:John.Thompson.JTSoftware@gmail.com">John.Thompson.JTSoftware@gmail.com</a><br><br></div>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></body></html>