[cfe-commits] r107953 - /cfe/trunk/lib/Basic/Targets.cpp

Eli Friedman eli.friedman at gmail.com
Fri Jul 9 11:43:56 PDT 2010


On Fri, Jul 9, 2010 at 11:27 AM, John Thompson
<john.thompson.jtsoftware at gmail.com> wrote:
>> As a first
> approximation, we could just chop off everything after the first comma
> (which would be enough to work for PR7338).
> Do you mean something like the enclosed patch?
>
> If so, may I check it in?

No, the check in question needs to happen in
CodeGenFunction::EmitAsmStmt, before we call validateOutputConstraint
or validateInputConstraint, or you won't end up with a valid asm in
the IR.

-Eli



More information about the cfe-commits mailing list