[cfe-commits] r107953 - /cfe/trunk/lib/Basic/Targets.cpp

[John Thompson]

> As a first
approximation, we could just chop off everything after the first comma
(which would be enough to work for PR7338).
Do you mean something like the enclosed patch?

If so, may I check it in?

-John
On Thu, Jul 8, 2010 at 10:55 PM, Eli Friedman <eli.friedman at gmail.com>wrote:

> On Thu, Jul 8, 2010 at 10:02 PM, John Thompson
> <john.thompson.jtsoftware at gmail.com> wrote:
> > Eli,
> >
> > I've reverted it.
> >
> > But would you either please reconsider or give me an alternative
> solution?
> >
> > A comment in bug 7338 mentions input from Andrew Pinsky, who I think is
> one
> > of the gcc guys, that gcc does ignore the commas.  But perhaps he just
> meant
> > our PS3 gcc.  If so, perhaps I could do it only for the PS3 target,
> rather
> > than for the PPC target, as I originally did?
> > The code in question using the commas is in the PS3 SDK headers, meaning
> > it's not so easy to change.
>
> I don't think he meant gcc ignores commas in general, just that in
> that particular case, the code is equivalent with and without commas.
> The correct solution is not in platform specific code; it's something
> like http://llvm.org/bugs/show_bug.cgi?id=7338#c6.  As a first
> approximation, we could just chop off everything after the first comma
> (which would be enough to work for PR7338).
>
> -Eli
>



-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100709/3ee32c1c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asmconcomma.patch
Type: application/octet-stream
Size: 717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100709/3ee32c1c/attachment.obj>