[cfe-commits] PATCH: Add somewhat hacky support for -fgnu-keywords and -fasm
dgregor at apple.com
Sat Apr 17 08:00:03 PDT 2010
Looks good. Please go ahead and commit.
On Apr 17, 2010, at 1:52 AM, Chandler Carruth wrote:
> On Mon, Apr 5, 2010 at 8:20 AM, Douglas Gregor <dgregor at apple.com> wrote:
> On Apr 3, 2010, at 12:58 AM, Chandler Carruth wrote:
> > I'm not exactly proud of this, but it works, and makes more sense than GCC's options. Basically it makes both '-fasm' and '-fgnu-keywords' (and their no- variants) synonyms for explicitly enabling or disabling GNU-extension keywords. This is actually the behavior of -fasm in GCC, their -fgnu-keywords is a more limited flag. If people see real benefit to supporting this distinction I can, but it didn't seem productive. It also doesn't make a lot of logical sense.
> GCC's behavior really doesn't make any sense, but this seems like a reasonable (sane) approximation.
> Please update the PCH reader and writer to serialize the GNUKeywords bit. Otherwise, looks good!
> Updated patch attached, thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits