<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks good. Please go ahead and commit.<div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br><div><div>On Apr 17, 2010, at 1:52 AM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Mon, Apr 5, 2010 at 8:20 AM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On Apr 3, 2010, at 12:58 AM, Chandler Carruth wrote:<br>
<br>
> I'm not exactly proud of this, but it works, and makes more sense than GCC's options. Basically it makes both '-fasm' and '-fgnu-keywords' (and their no- variants) synonyms for explicitly enabling or disabling GNU-extension keywords. This is actually the behavior of -fasm in GCC, their -fgnu-keywords is a more limited flag. If people see real benefit to supporting this distinction I can, but it didn't seem productive. It also doesn't make a lot of logical sense.<br>
<br>
</div>GCC's behavior really doesn't make any sense, but this seems like a reasonable (sane) approximation.<br>
<br>
Please update the PCH reader and writer to serialize the GNUKeywords bit. Otherwise, looks good!<br></blockquote><div><br></div><div>Updated patch attached, thanks!</div></div>
<span><add-gnu-keywords.patch></span></blockquote></div><br></div></body></html>