[cfe-commits] [Review] rollingout ASTContext::getTypeSizeInBytes()

Ken Dyck Ken.Dyck at onsemi.com
Thu Nov 26 10:05:51 PST 2009

On Wednesday, November 25, 2009 4:09 PM, John McCall wrote:
> Ken Dyck wrote: 
> >
> > Okay. I'll take a stab at implementing this. 
> > 		
> > As I understand it, these are the changes that need to happen:
> > 
> > [snipped]
> > 		
> > Is this what you had in mind?
> I was thinking more along the lines of a type that represented a 
> size/offset in bytes;  call it bytes_t for the sake of argument.  
> [snipped]

Okay. As a nested class in ASTContext? Or as a stand-alone class? 

Since we're making changes to the API anyways, what do you think of the
units being bytes? The getTypeSizeInBytes() method returns the size of
the type in characters, so it would be more accurate to call the units
chars_t. And if we're doing that, we might as well change the method
names to 'getTypeSizeInChars()' and 'getCharWidth()', too.


More information about the cfe-commits mailing list