[cfe-commits] r86106 - in /cfe/trunk: include/clang/Lex/Preprocessor.h lib/Lex/Preprocessor.cpp

Chris Lattner clattner at apple.com
Wed Nov 4 23:06:53 PST 2009


On Nov 4, 2009, at 10:50 PM, Daniel Dunbar wrote:

>>>
>>> Chris, please review. I debated splitting into const/non-const  
>>> versions
>>> where
>>> the const one propogated constness to the resulting IdentifierInfo*.
>>
>> That wouldn't make sense, because creating the identifier is the  
>> mutation
>> point.
>
> Yes, but clients that have a const Preprocessor probably shouldn't be
> allowed to mutate the IdentifierInfo that lives inside it?

Sure, that works for me.

-Chris



More information about the cfe-commits mailing list