[cfe-commits] r86106 - in /cfe/trunk: include/clang/Lex/Preprocessor.h lib/Lex/Preprocessor.cpp

[Daniel Dunbar]

On Wed, Nov 4, 2009 at 8:05 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Nov 4, 2009, at 5:53 PM, Daniel Dunbar wrote:
>
>> Author: ddunbar
>> Date: Wed Nov  4 19:53:52 2009
>> New Revision: 86106
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=86106&view=rev
>> Log:
>> Make LookUpIdentifierInfo const. This makes the Identifiers table mutable
>> and is
>> a little fuzzy, but conceptually it's just uniquing the identifier.
>>
> This is fine with me.
>
>> Chris, please review. I debated splitting into const/non-const versions
>> where
>> the const one propogated constness to the resulting IdentifierInfo*.
>
> That wouldn't make sense, because creating the identifier is the mutation
> point.

Yes, but clients that have a const Preprocessor probably shouldn't be
allowed to mutate the IdentifierInfo that lives inside it?

 - Daniel

> -Chris
>
>