[cfe-commits] r65233 - in /cfe/trunk/lib: AST/ASTContext.cpp Analysis/CFRefCount.cpp

[Ted Kremenek]

On Feb 21, 2009, at 10:16 AM, Cédric Venet wrote:

>> Generally portability issues should be handled by adding a portable
>> API to llvm (for example, llvm::System which encapsulates the  
>> features
>> needed. In this case the right place would be StringExtras.h, we
>> already have StringEqualsNoCase, for example.
>>
>>
>
> Yes I was thinking to put it here at first, but was unsure if I should
> put a clang specific in the llvm files. I suppose that since the  
> support
> api are commun to the two it is not  a problem...
>
> Now, should I create a function StringEqualsNoCaseN (or
> StringCmpNoCaseSafe) or using a macro to define strncasecmp is fine?
>
> regards,
>
> Cédric

I'm about to commit a StringEqualsNoCase that takes a length  
argument.  CFRefCount.cpp will use it.