[cfe-commits] r65233 - in /cfe/trunk/lib: AST/ASTContext.cpp Analysis/CFRefCount.cpp

[Ted Kremenek]

On Feb 21, 2009, at 10:16 AM, Cédric Venet wrote:

> Daniel Dunbar a écrit :
>> On Sat, Feb 21, 2009 at 9:14 AM, Cedric Venet <cedric.venet at laposte.net 
>> > wrote:
>>
>>> Author: venet
>>> Date: Sat Feb 21 11:14:49 2009
>>> New Revision: 65233
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=65233&view=rev
>>> Log:
>>> Fix build on windows.
>>>
>>> Should clang have a config.h or should we use the config.h of llvm  
>>> or using the preprocessor is OK?  I did a quick fix here, but  
>>> having a guideline on how to handle non portable function would be  
>>> great (or ask ted to stop breaking the windows build :)).
>>>
>>
>> No on config.h.
>>
>> Generally portability issues should be handled by adding a portable
>> API to llvm (for example, llvm::System which encapsulates the  
>> features
>> needed. In this case the right place would be StringExtras.h, we
>> already have StringEqualsNoCase, for example.
>>
>>
>
> Yes I was thinking to put it here at first, but was unsure if I should
> put a clang specific in the llvm files. I suppose that since the  
> support
> api are commun to the two it is not  a problem...
>
> Now, should I create a function StringEqualsNoCaseN (or
> StringCmpNoCaseSafe) or using a macro to define strncasecmp is fine?

Committed:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090216/074084.html

and

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090216/012914.html

Cedric: Thanks for pointing out that strncasecmp isn't portable.