[cfe-commits] r42070 - in /cfe/trunk: AST/Decl.cpp Parse/ParseObjc.cpp Sema/Sema.h Sema/SemaDecl.cpp include/clang/AST/Decl.h include/clang/Parse/Action.h include/clang/Parse/Parser.h

[Fariborz Jahanian]

On Sep 17, 2007, at 4:32 PM, Steve Naroff wrote:

>
> On Sep 17, 2007, at 3:36 PM, Fariborz Jahanian wrote:
>
>> -Parser::DeclTy *Parser::ParseObjCMethodDecl(DeclTy *IDecl,
>> -                          tok::ObjCKeywordKind& pi,
>> +Parser::DeclTy *Parser::ParseObjCMethodDecl(tok::ObjCKeywordKind&  
>> pi,
>>  			  tok::TokenKind mType, SourceLocation mLoc) {
>
>> +  virtual DeclTy *ObjcBuildMethodDeclaration(tok::ObjCKeywordKind&  
>> pi,
>>  		    SourceLocation MethodLoc,
>>  	            tok::TokenKind MethodType, TypeTy *ReturnType,
>>       		    ObjcKeywordDecl *Keywords, unsigned NumKeywords,
>>       		    AttributeList *AttrList);
>
> Looks good. Some comments...
>
> - Why is "pi" passed by reference?

No longer is necessary (was left over from a previous patch).

> - The name ("pi") could be a little more descriptive:-)

OK.

> - Since this argument is only needed for protocols, I would have  
> preferred it be added to the end of the respective argument lists  
> (with a default argument). This way, fewer clients would need to be  
> aware of data that is protocol specific...

OK.

Patch is coming shortly.

- fj

>
> snaroff
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20070917/6694fd97/attachment.html>