<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<br><div><div>On Sep 17, 2007, at 4:32 PM, Steve Naroff wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><br><div><div>On Sep 17, 2007, at 3:36 PM, Fariborz Jahanian wrote:</div><div><br class="khtml-block-placeholder"></div><blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">-Parser::DeclTy *Parser::ParseObjCMethodDecl(DeclTy *IDecl,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">- tok::ObjCKeywordKind& pi, </div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">+Parser::DeclTy *Parser::ParseObjCMethodDecl(tok::ObjCKeywordKind& pi, </div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <span class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "> </span><span class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "> </span><span class="Apple-tab-span" style="white-space:pre; color: rgb(0, 0, 221); "> </span> tok::TokenKind mType, SourceLocation mLoc) {</div></blockquote><br><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">+ virtual DeclTy *ObjcBuildMethodDeclaration(tok::ObjCKeywordKind& pi,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> SourceLocation MethodLoc,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <span class="Apple-tab-span" style="white-space:pre"> </span> tok::TokenKind MethodType, TypeTy *ReturnType,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> ObjcKeywordDecl *Keywords, unsigned NumKeywords,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> AttributeList *AttrList);</div></blockquote></div><div><br class="khtml-block-placeholder"></div></div>Looks good. Some comments...<div><br class="khtml-block-placeholder"><div><div>- Why is "pi" passed by reference?</div></div></div></div></blockquote><div><br class="webkit-block-placeholder"></div>No longer is necessary (was left over from a previous patch).</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><div><div><div>- The name ("pi") could be a little more descriptive:-)</div></div></div></div></blockquote><div><br class="webkit-block-placeholder"></div>OK.</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><div><div><div>- Since this argument is only needed for protocols, I would have preferred it be added to the end of the respective argument lists (with a default argument). This way, fewer clients would need to be aware of data that is protocol specific...</div></div></div></div></blockquote><div><br class="webkit-block-placeholder"></div>OK.</div><div><br class="webkit-block-placeholder"></div><div>Patch is coming shortly.</div><div><br class="webkit-block-placeholder"></div><div>- fj</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><div><div><div><br class="khtml-block-placeholder"></div><div>snaroff<br><div><br class="khtml-block-placeholder"></div></div></div></div></div></blockquote></div><br></body></html>