[vmkit-commits] Add class lock and condition variable to AOT compiled classes

[Allan Tong]

Ok, sounds good.

 - Allan

On Fri, Sep 24, 2010 at 1:50 PM, nicolas geoffray
<nicolas.geoffray at gmail.com> wrote:
> Thanks very much Allan for the debugging and the patch!
> Thinking about it, I think we should get rid of these variables in the
> JavaClass class. I plan on doing this soon.
> Cheers,
> Nicolas
>
> On Thu, Sep 23, 2010 at 3:09 AM, Allan Tong <actong88 at gmail.com> wrote:
>>
>> Revision 111399 breaks AOT compiled code.  The thin lock was removed
>> from the LLVM class structure, but the new lock and condition variable
>> were not added.  When loading the AOT compiled class, the lock and
>> condition members would access memory outside of the object.  Trying
>> to run a hello world with a precompiled libvmjc.so resulted in an
>> assertion in the pthread library since the mutex contained garbage
>> data:
>>
>> j3: tpp.c:63: __pthread_tpp_change_priority: Assertion `new_prio == -1
>> || (new_prio >= __sched_fifo_min_prio && new_prio <=
>> __sched_fifo_max_prio)' failed.
>>
>> The attached patch should fix the issue.  I modeled the pthread
>> structures as byte arrays, and while I believe the alignment should be
>> correct, I'm not sure if there isn't some better way of doing this.
>>
>> Also note that the patch does not include the regenerated configure
>> script.  Only the changes to configure.ac are included.
>>
>>  - Allan
>>
>> _______________________________________________
>> vmkit-commits mailing list
>> vmkit-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits
>>
>
>
> _______________________________________________
> vmkit-commits mailing list
> vmkit-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits
>
>