[Parallel_libs-commits] [parallel-libs] r281091 - [StreamExecutor] Make SE work with an in-tree LLVM build.

[Hal Finkel via Parallel_libs-commits]

Hi Justin,

I'm seeing a problem configuring a build that has both parallel-libs and lld in-tree...

CMake Error at cmake/modules/AddLLVM.cmake:645 (add_executable):
  add_executable cannot create target "CoreTests" because another target with
  the same name already exists.  The existing target is an executable created
  in source directory
  "path/to/llvm/projects/parallel-libs/streamexecutor/unittests/CoreTests".
  See documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  cmake/modules/AddLLVM.cmake:977 (add_llvm_executable)
  tools/lld/unittests/CMakeLists.txt:11 (add_unittest)
  tools/lld/unittests/CoreTests/CMakeLists.txt:1 (add_lld_unittest)

 -Hal

----- Original Message -----
> From: "Justin Lebar via Parallel_libs-commits" <parallel_libs-commits at lists.llvm.org>
> To: "parallel libs-commits" <parallel_libs-commits at lists.llvm.org>
> Sent: Friday, September 9, 2016 4:01:03 PM
> Subject: [Parallel_libs-commits] [parallel-libs] r281091 - [StreamExecutor] Make SE work with an in-tree LLVM build.
> 
> Author: jlebar
> Date: Fri Sep  9 16:01:02 2016
> New Revision: 281091
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=281091&view=rev
> Log:
> [StreamExecutor] Make SE work with an in-tree LLVM build.
> 
> Summary:
> With these changes, we can put parallel-libs within llvm/projects and
> build as normal.
> 
> This is kind of the minimal change I could figure out how to make
> while
> still making us compatible with llvm's build system.  Some things I'm
> not thrilled about include:
> 
>  * The creation of a CoreTests directory (the macros really seemed to
>    want this)
> 
>  * Pulling SimpleHostPlatformDevice.h into CoreTests.  It seems to me
>    this should live inside unittests/include, or maybe tests/include,
>    but I didn't want to make that change in this patch.
> 
> One important piece of work that remains to be done is to make
> 
>   $ ninja check-streamexecutor
> 
> run all the tests.  Right now the only way I've figured out to run
> the
> tests is
> 
>   $ ninja
>   projects/parallel-libs/streamexecutor/unittests/StreamExecutorUnitTests
>   $
>   projects/parallel-libs/streamexecutor/unittests/CoreTests/CoreTests
> 
> Reviewers: jhen
> 
> Subscribers: beanz, parallel_libs-commits, jprice
> 
> Differential Revision: https://reviews.llvm.org/D24368
> 
> Added:
>     parallel-libs/trunk/CMakeLists.txt
>     parallel-libs/trunk/streamexecutor/lib/Utils/CMakeLists.txt
>     parallel-libs/trunk/streamexecutor/unittests/
>     parallel-libs/trunk/streamexecutor/unittests/CMakeLists.txt
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/CMakeLists.txt
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/DeviceTest.cpp
>       - copied, changed from r280955,
>       parallel-libs/trunk/streamexecutor/lib/unittests/DeviceTest.cpp
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/KernelSpecTest.cpp
>       - copied, changed from r280955,
>       parallel-libs/trunk/streamexecutor/lib/unittests/KernelSpecTest.cpp
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/PackedKernelArgumentArrayTest.cpp
>       - copied, changed from r280955,
>       parallel-libs/trunk/streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/SimpleHostPlatformDevice.h
>       - copied, changed from r280955,
>       parallel-libs/trunk/streamexecutor/lib/unittests/SimpleHostPlatformDevice.h
>     parallel-libs/trunk/streamexecutor/unittests/CoreTests/StreamTest.cpp
>       - copied, changed from r280955,
>       parallel-libs/trunk/streamexecutor/lib/unittests/StreamTest.cpp
> Removed:
>     parallel-libs/trunk/streamexecutor/lib/unittests/CMakeLists.txt
>     parallel-libs/trunk/streamexecutor/lib/unittests/DeviceTest.cpp
>     parallel-libs/trunk/streamexecutor/lib/unittests/KernelSpecTest.cpp
>     parallel-libs/trunk/streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp
>     parallel-libs/trunk/streamexecutor/lib/unittests/SimpleHostPlatformDevice.h
>     parallel-libs/trunk/streamexecutor/lib/unittests/StreamTest.cpp
> Modified:
>     parallel-libs/trunk/streamexecutor/CMakeLists.txt
>     parallel-libs/trunk/streamexecutor/lib/CMakeLists.txt
> 
> Added: parallel-libs/trunk/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/parallel-libs/trunk/CMakeLists.txt?rev=281091&view=auto
...
> 
> 
> _______________________________________________
> Parallel_libs-commits mailing list
> Parallel_libs-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/parallel_libs-commits
> 

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory