[Parallel_libs-commits] [PATCH] D24580: [SE] Let users specify CUDA path

[James Price via Parallel_libs-commits]

jprice added a comment.

In https://reviews.llvm.org/D24580#543239, @jhen wrote:

> Thanks for bringing this up! I added logic to `streamexecutor-config` to add in the CUDA library for the `--libs` output if CUDA is enabled. It seems to work on Ubuntu. I'd definitely be glad to know if it works on OS X as well.


Alas, this still doesn't work for OS X. It seems that `CUDA_DRIVER_LIBRARY` is set to the full path to the framework (e.g. `/Library/Frameworks/cuda.framework`) whereas the flag that needs to be passed is `-framework cuda`. CMake automagically sorts this out when passing the framework path to `target_link_libraries`, but I'm not sure there's a simple way of getting it to spit out the correct flag for `streamexecutor-config` in a platform independent manner.

This doesn't have to hold up this patch BTW, I just thought I'd mention it here since I noticed it.


https://reviews.llvm.org/D24580