[Parallel_libs-commits] [PATCH] D24580: [SE] Let users specify CUDA path

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

In https://reviews.llvm.org/D24580#543120, @jprice wrote:

> Does this also need the CUDA library to be added to `streamexecutor-config` output for `--libs`?
>
> At the moment (with this patch), if I try and link against SE using `streamexecutor-config`, I get undefined references to all of the CUDA driver functions. If I manually add `-framework cuda` (OS X), it all works. The CUDA SAXPY example works for me, but I can see from the verbose ninja output that the example is building with `-framework cuda` already.


Thanks for bringing this up! I added logic to `streamexecutor-config` to add in the CUDA library for the `--libs` output if CUDA is enabled. It seems to work on Ubuntu. I'd definitely be glad to know if it works on OS X as well.


================
Comment at: streamexecutor/lib/platforms/cuda/cmake/modules/FindLibcuda.cmake:1

----------------
I think this was a phabricator bug. This whole file is gone from my standpoint (and I'm glad it's gone :)).


https://reviews.llvm.org/D24580