[Parallel_libs-commits] [PATCH] D24538: [SE] Add CUDA platform

[James Price via Parallel_libs-commits]

jprice added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/platforms/cuda/CUDAPlatformDevice.h:23
@@ +22,3 @@
+
+Error CUresultToError(int CUResult);
+
----------------
Where is this defined? I get undefined references to this function when I try and build this patch.

================
Comment at: streamexecutor/include/streamexecutor/platforms/cuda/CUDAPlatformDevice.h:37
@@ +36,3 @@
+
+  std::string getName() const override { return "CUDA"; }
+
----------------
jlebar wrote:
> Do we want the device number in the name?
Or even the actual name of the device (`cuDeviceGetName`)? This is certainly more useful for client code (in my experience), particularly when working with systems that have more than one type of GPU.

It strikes me that "CUDA" is really the name of the platform, not the device. In which case, maybe it makes sense to also have a `getPlatformName()` or `getPlatform()->getName()` that gives you the "CUDA" vs "OpenCL" vs "Host" which is used for the error strings.



https://reviews.llvm.org/D24538