[Parallel_libs-commits] [PATCH] D24468: [SE] Add .clang-format

Jason Henline via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Mon Sep 12 12:24:12 PDT 2016


jhen created this revision.
jhen added reviewers: jlebar, jprice.
jhen added a subscriber: parallel_libs-commits.

The .clang-tidy file is copied from the top-level LLVM source directory
with one change: I removed the misc-noexcept-move-constructor check
because it seemed to be triggering a lot of false positives, and I
didn't think it was necessary because StreamExecutor will usually be
compiled without exceptions enabled.

Also fix warnings generated by clang-format:

* Moved SimpleHostPlatformDevice.h so its header include guard could
  have the right format.
* Changed signatures of methods taking llvm::Twine by value to take it
  by const ref instead.
* Removed a bunch of places where single-statement loops and
  conditionals were surrounded with braces. (This was not found by the
  current clang-tidy, but with a local patch that I hope to upstream
  soon.)

https://reviews.llvm.org/D24468

Files:
  .clang-tidy
  streamexecutor/include/streamexecutor/Device.h
  streamexecutor/include/streamexecutor/Error.h
  streamexecutor/include/streamexecutor/KernelSpec.h
  streamexecutor/include/streamexecutor/Stream.h
  streamexecutor/include/streamexecutor/unittests/CoreTests/SimpleHostPlatformDevice.h
  streamexecutor/lib/Device.cpp
  streamexecutor/lib/DeviceMemory.cpp
  streamexecutor/lib/Error.cpp
  streamexecutor/lib/HostMemory.cpp
  streamexecutor/lib/KernelSpec.cpp
  streamexecutor/unittests/CoreTests/DeviceTest.cpp
  streamexecutor/unittests/CoreTests/PackedKernelArgumentArrayTest.cpp
  streamexecutor/unittests/CoreTests/SimpleHostPlatformDevice.h
  streamexecutor/unittests/CoreTests/StreamTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24468.71041.patch
Type: text/x-patch
Size: 27012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/parallel_libs-commits/attachments/20160912/f2781368/attachment-0001.bin>


More information about the Parallel_libs-commits mailing list