[Parallel_libs-commits] [PATCH] D24368: [StreamExecutor] Make SE work with an in-tree LLVM build.

[Jason Henline via Parallel_libs-commits]

jhen added a comment.




================
Comment at: streamexecutor/lib/CMakeLists.txt:2
@@ +1,3 @@
+macro(add_se_library name)
+  add_llvm_library(${name} ${ARGN})
+  set_target_properties(${name} PROPERTIES FOLDER "streamexecutor libraries")
----------------
This breaks the standalone build because it doesn't recognize `add_llvm_library`.

================
Comment at: streamexecutor/unittests/CMakeLists.txt:5
@@ +4,3 @@
+function(add_se_unittest testdir_name)
+  add_unittest(StreamExecutorUnitTests ${testdir_name} ${ARGN})
+  target_link_libraries(${testdir_name} streamexecutor)
----------------
I think `add_unittest` is also defined by the LLVM cmake files, so the standalone build will break here too.


https://reviews.llvm.org/D24368