[Parallel_libs-commits] [PATCH] D24353: [SE] RegisteredHostMemory for async device copies

[James Price via Parallel_libs-commits]

jprice added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/Device.h:86
@@ -104,1 +85,3 @@
+  /// destination in these copy methods, so there is no need to register that
+  /// hsot memory with registerHostMemory.
   ///
----------------
host

================
Comment at: streamexecutor/include/streamexecutor/HostMemory.h:105
@@ +104,3 @@
+/// Can be created by registering previously allocated host memory or by newly
+/// allocating registered host memory. If created by registering previously
+/// allocated host memory, it does not own the underlying host memory pointer,
----------------
"newly allocating registered host memory" isn't an option anymore

================
Comment at: streamexecutor/include/streamexecutor/HostMemory.h:107-109
@@ +106,5 @@
+/// allocated host memory, it does not own the underlying host memory pointer,
+/// so it just unregisters the memory upon destruction. If created by newly
+/// allocating registered host memory, then it owns the underlyhing host memory
+/// pointer and will free it during destruction.
+class RegisteredHostMemoryBase {
----------------
Likewise - this last sentence isn't valid anymore


https://reviews.llvm.org/D24353