[Parallel_libs-commits] [PATCH] D24302: Add streamexecutor-config

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

Well, it turns out that the current llvm-config does not handle directories with special characters. I built llvm with `-DCMAKE_INSTALL_PREFIX="$HOME/private/dir 'with' spaces"` and installed it there. Then when I ran `llvm-config --cppflags` I got the following output:

  -I/usr/local/google/home/jhen/private/dir 'with' spaces/include   -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS

where we can see that the spaces and single quotes have not been escaped.

I think we should mimic the llvm-config behavior because otherwise there will be two separate ways that paths are formatted in the output, and if anyone ever does make a workaround for llvm-config, it won't work for streamexecutor-config.

So I would say that even though it's kind of pathetic, I think we should not try to escape special characters in our output either.


https://reviews.llvm.org/D24302