[Parallel_libs-commits] [PATCH] D24302: Add streamexecutor-config

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

In https://reviews.llvm.org/D24302#536251, @jlebar wrote:

> OK.  The python code `'\"'` is equivalent to the string containing one character, double-quote.  So I think this is good so long as ESCAPE_QUOTES also escapes backslashes as `\\` (which we care about because Windows filenames contain backslashes).


It turns out that ESCAPE_QUOTES doesn't do the right thing for Python because it is only meant for C string literals. So, for example, it doesn't escape single quotes. So I removed the ESCAPE_QUOTES option for cmake configure_file and instead wrapped the substitution in triple double quotes. This will still break if the path contains triple double quotes, but I'm willing to let that happen.

Between this change and the change to using LLVM_BINARY_DIRECTORY for the llvm-config path, jlebar, I think you might want to take another quick glance to make sure things still look OK.


================
Comment at: streamexecutor/tools/streamexecutor-config/streamexecutor-config.in:149
@@ +148,3 @@
+        'llvm-config not found in PATH, please add it to the PATH and retry')
+
+  all_flags = []
----------------
I think that's a good idea. I made that change and added another option to let the user override the llvm-config path if the configuration somehow goes wrong.


https://reviews.llvm.org/D24302