[Parallel_libs-commits] [PATCH] D24302: Add streamexecutor-config

[James Price via Parallel_libs-commits]

jprice added inline comments.

================
Comment at: streamexecutor/tools/streamexecutor-config/streamexecutor-config.in:148
@@ +147,3 @@
+    sys.exit(
+        'llvm-config not found in PATH, please add it to the PATH and retry')
+
----------------
I wonder if it's worth automatically picking out the path to `llvm-config` using `@LLVM_BINARY_DIR@` instead of relying on it being on `PATH`. Makes things slightly easier for the user, and reduces the risk that they have a different LLVM on their `PATH` to the one that SE was built against.


https://reviews.llvm.org/D24302