[Parallel_libs-commits] [PATCH] D24213: [SE] Remove Platform*Handle classes

[Justin Lebar via Parallel_libs-commits]

jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.

Seems simpler to me!


================
Comment at: streamexecutor/lib/Kernel.cpp:27
@@ +26,3 @@
+      DemangledName(
+          llvm::symbolize::LLVMSymbolizer::DemangleName(Name, nullptr)) {}
+
----------------
Can we assert that PDevice and PlatformKernelHandle are not null?  Otherwise we'll find out that PDevice was null only when we destroy the KernelBase.

================
Comment at: streamexecutor/lib/Stream.cpp:21
@@ -21,2 +20,3 @@
+    : PDevice(D), PlatformStreamHandle(PlatformStreamHandle),
       ErrorMessageMutex(llvm::make_unique<llvm::sys::RWMutex>()) {}
 
----------------
Same for assertions here.


https://reviews.llvm.org/D24213