[Parallel_libs-commits] [PATCH] D24195: [SE] GlobalDeviceMemory owns its handle

[Justin Lebar via Parallel_libs-commits]

jlebar accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: streamexecutor/include/streamexecutor/DeviceMemory.h:167
@@ -163,3 +166,3 @@
 /// GlobalDeviceMemoryBase that represents a buffer of integers stored in global
 /// device memory.
 template <typename ElemT>
----------------
Right, I don't think visibility matters because visibility doesn't factor into C++ overloading rules.

I think it's sort of cleaner to put them up top like you did here because the fact that it's not copyable is in reality part of the "public interface".


https://reviews.llvm.org/D24195